search

amarullz / windowgestures

GNOME Extension to Manage window with touchpad gestures
https://amarullz.com/
GNU General Public License v2.0
63 stars 10 forks source link

Are there plans to adapt extensions for gnome 46? #26

Open tulashvili opened 8 months ago

tulashvili commented 8 months ago

I really enjoyed using your extension, but my system automatically upgraded to gnome 46 and now I'm frustrated as I can't use it

FelixFourcolor commented 8 months ago

If you add version 46 to the metadata, you'll find that it still mostly "sort of" works. The extension runs without error, but some gestures don't work anymore.

I use swipe 3 fingers down to minimize, pinch 3 fingers to close, and swipe 4 fingers left/right to send window to the next workspace. Only the pinch gesture stopped working.

But yes, I'd greatly appreciate it if this is properly ported to gnome 46.

amarullz commented 8 months ago

Will look into it if I have a hand on 46. Currently 45 is my main workstation.

oktayacikalin commented 7 months ago

Fedora 40 just got released with Gnome 46. Please reevaluate. I really like your extension very much. Thank you!

janwil123 commented 7 months ago

Fedora 40 just got released with Gnome 46. Please reevaluate. I really like your extension very much. Thank you!

Please add my vote as well :) I got the extension working by manually adding 46 to the manifest, but I have not tested all the functionality, there may be something that needs a developer eye.

sidevesh commented 7 months ago

@amarullz were you able to upgrade to Gnome 46 and look into upgrading the extension to support it ?

jasiralavibiztripz commented 7 months ago

Just upgraded to Ubuntu 22.04 (Gnome 46) and saw this is no longer working. So used to the extension and customized gestures. Please update to get it working for gnome46

sidevesh commented 7 months ago

@benyaminl that does get the extension working again on 46, although I have noticed that 3 finger pinch and hold gestures don't work anymore,

which is exactly the same issue that the transpiled version of gnome-gesture-improvements (https://github.com/sidevesh/gnome-gesture-improvements--transpiled) have when they are bought over to 46. Clearly something has changed in how pinch and hold 3 (4 also?) finger gestures are communicated by shell.

FelixFourcolor commented 7 months ago

@benyaminl It's not that simple, see my earlier comment.

If you add version 46 to the metadata, you'll find that it still mostly "sort of" works. The extension runs without error, but some gestures don't work anymore.

I use swipe 3 fingers down to minimize, pinch 3 fingers to close, and swipe 4 fingers left/right to send window to the next workspace. Only the pinch gesture stopped working.

But yes, I'd greatly appreciate it if this is properly ported to gnome 46.

jasiralavibiztripz commented 7 months ago

If you add version 46 to the metadata, you'll find that it still mostly "sort of" works. The extension runs without error, but some gestures don't work anymore.

I use swipe 3 fingers down to minimize, pinch 3 fingers to close, and swipe 4 fingers left/right to send window to the next workspace. Only the pinch gesture stopped working.

But yes, I'd greatly appreciate it if this is properly ported to gnome 46.

Editing the metadata pretty much worked for me. Apart from Tap-hold to move windows, all my settings seem to be working well. But I hope you fix it soon. Thanks fr the great extension!

amarullz commented 6 months ago

updating to ubuntu 24...

amarullz commented 6 months ago

In Gnome 46 the extension cannot get the Tap-Hold and Pinch event when the mouse pointer is above a window, it's still works when pointer is on workspace/desktop.

amarullz commented 6 months ago

Release as is for now. I still cannot be able to get hold & pinch event if pointer is above window.

I will find other solutions for it, or will hide the feature in 46

sidevesh commented 6 months ago

saw your commit @amarullz hiding the pinch and hold gestures on 46, it's sad that they broke these useful gestures in 46 but before giving up can you try contacting the gnome team (https://handbook.gnome.org/get-in-touch/matrix.html) about this regression ? The gestures seem to be coming from clutter and that does not seem to be very actively changing, I am suspecting that https://gitlab.gnome.org/GNOME/mutter/-/commits/main/clutter?ref_type=undefined might be related to this.

amarullz commented 6 months ago

pinch and tap-hold gesture still available but not in global scope.

I don't remove it, just add a some statement to disable it (temporary for now) if gnome version >= 46.

Still finding the right way to do it, I tested everything yesterday and find any commit related in gnome shell. will take a look at clutter

sidevesh commented 6 months ago

I have opened an issue on Gnome shell repo which also contains the clutter code, https://gitlab.gnome.org/GNOME/mutter/-/issues/3472

In case my description of the issue is incorrect or if you have more info on this @amarullz then let me know and I will update it there, or you can add a comment in that issue also. I hope this gets fixed / handled, without gestures the Gnome experience with touchpad is too slow.