amarullz / windowgestures

GNOME Extension to Manage window with touchpad gestures
https://amarullz.com/
GNU General Public License v2.0
44 stars 6 forks source link

Migrating functionalities from GNOME Gesture Improvements to WindowGestures #3

Open D3vil0p3r opened 9 months ago

D3vil0p3r commented 9 months ago

Is it possible to migrate the features of the unmaintained GNOME Gesture Improvements project to this one?

amarullz commented 9 months ago

It's main idea actually from Gesture Improvements but implementing from scratch. For window gestures, it almost have everything from Gesture Improvements (except maybe minimize) and add more functions.

I don't know about workspace gestures, still don't want messing around with existing gnome gestures. But maybe if I can get cleaner workaround, I will try to implementing it.

DarkXero-dev commented 9 months ago

Does this require anything extra like the daemon similar to Gesture Improvements ? Or is this just an extension without any extra requirements ?

Reason I am asking is because I am a Distro Maintainer XeroLinux and currently looking to replace Gesture Improvements since it's unmaintained now. Maybe more information on the Readme ?

Thanks

amarullz commented 9 months ago

Currently it support only in wayland (I don't think it will work ootb with X11) This extensions doesn't use any daemon / external program. extension.js basically handle everything and implemented in clean, simple and easier to understand.

It's only use official gnome-js APIs https://gjs-docs.gnome.org/

DarkXero-dev commented 9 months ago

Owner

Oh only Wayland. Ok thanks. Any plans for X11 ? I know it's a dying project but some still use it for compatibility until Wayland is fully mature ..

amarullz commented 9 months ago

I will try X11, but I think It will need gnome-x11-gesture-daemon, because even gnome default gestures will not works in X11 without it.

Edit: Ah, https://extensions.gnome.org/extension/4033/x11-gestures/ not supported 45 yet!

DarkXero-dev commented 9 months ago

I will try X11, but I think It will need gnome-x11-gesture-daemon, because even gnome default gestures will not works in X11 without it.

Ah, https://extensions.gnome.org/extension/4033/x11-gestures/ not supported 45 yet!

I already have that in my Distro due to the other Extension.. Yeah I know not yet compatible.. Hence why am asking. But they say they support it on This Post

amarullz commented 9 months ago

I already have that in my Distro due to the other Extension.. Yeah I know not yet compatible.. Hence why am asking. But they say they support it on This Post

That extension not work with ubuntu 23.10 beta. not extension but touchegg not work.. will try again later.

DarkXero-dev commented 9 months ago

Well am on Arch will wait n see.. thanks for the hard work ;)

YaQia commented 9 months ago

The pinch feature is needed most for me. I often use three finger pinch to close windows. Hope to see it.

amarullz commented 9 months ago

I think the best way to implementing it (if I can implement the pinch) is implementing pinch to keyboard shortcut, so user can customize it as they want.

DarkXero-dev commented 9 months ago

To be honest I do not use it myself I prefer a regular external mouse (Trackball). I include it on my Distribution to satisfy those who like it and prefer it.

amarullz commented 9 months ago

The pinch feature is needed most for me. I often use three finger pinch to close windows. Hope to see it.

Can you open new issue for pinch?. On progress adding it. Because it was just subset of Gesture Improvement featues.

Screenshot from 2023-10-11 02-00-25

DarkXero-dev commented 9 months ago

Looking good.. I wait for X11 support once that's done will test it then add it to my Distro.. Great job..

amarullz commented 9 months ago

Pinch Pre-Release https://github.com/amarullz/windowgestures/releases/tag/2.1-pre3

Screenshot from 2023-10-11 04-27-17

sidevesh commented 9 months ago

@amarullz Can you add setting to show notification list or quick settings toggle on pinch ? I had raised a PR for this in gnome-gesture-improvements but looks like that isnt gonna get merged as its unmaintained https://github.com/harshadgavali/gnome-gesture-improvements/issues/201

amarullz commented 9 months ago

@amarullz Can you add setting to show notification list or quick settings toggle on pinch ? I had raised a PR for this in gnome-gesture-improvements but looks like that isnt gonna get merged as its unmaintained https://github.com/harshadgavali/gnome-gesture-improvements/issues/201

Screenshot_2023-10-11-14-35-49-11_320a9a695de7cdce83ed5281148d6f19.jpg

already in pinch action. see pre3 release

sidevesh commented 9 months ago

great! also, can you add a toggle to disable fullscreening window if already maximized ? again something that I had raised a PR for on gnome-gesture-improvements :(

sidevesh commented 9 months ago

Also, while I like the move window around using gesture, is it possible to support snapping to left / right on a gesture down then to the side like gnome-gesture-improvements ? I had gotten used to this gesture quite a bit

sidevesh commented 9 months ago

Also, the way gnome-gesture-improvements implemented the switch windows using horizontal swipes by showing the alt tab style list of windows was quite nice and similar to how Windows does it.

sidevesh commented 9 months ago

I think I have created issues for all the features of gnome-gesture-improvements that I was aware of, @D3vil0p3r if you see anything missing then let me know here, or we can close this ticket once we have covered every missing feature.

D3vil0p3r commented 9 months ago

Thank you @sidevesh . Up to @amarullz to keep it opened or closing it and work on each issue ticket directly.

D3vil0p3r commented 9 months ago

Is there in GNOME extensions page this WindowGestures tool?

amarullz commented 9 months ago

https://extensions.gnome.org/extension/6343/window-gestures/

Still in ver 2. I want to add more features,config & bug fixes before next ext submit.

amarullz commented 8 months ago

I think beta3 already implement majority gesture Improvements features.

https://github.com/amarullz/windowgestures/releases/tag/3.0-beta3

Inform me if there is more interesting/useful features that missing.

lcrippa commented 8 months ago

Thanks a lot for the very nice work. Perhaps the possibility of tiling the window on the left-right half of the screen would be nice (3-finger swipe down-left/right in the old gesture-improvements extension)

amarullz commented 8 months ago

Thanks a lot for the very nice work. Perhaps the possibility of tiling the window on the left-right half of the screen would be nice (3-finger swipe down-left/right in the old gesture-improvements extension)

Already implemented. Swipe 4 finger up then left/right (4 fingers can be swapped with 3 fingers). Also take a look extension settings, you have many configurations for your needs.

andrewaclear commented 8 months ago

Will X11 support be looked into?