search

amasad / eHistory

A Google Chrome extensions that enhances the browser's history search and management in many ways.
https://chrome.google.com/extensions/detail/hiiknjobjfknoghbeelhfilaaikffopb?hl=en
MIT License
41 stars 9 forks source link

Do not add filter values to search text #17

Open petr-tichy opened 10 years ago

petr-tichy commented 10 years ago

When filtering using isurl key, the search wasn't returning all entries

amasad commented 10 years ago

Could you give a little bit more context about this. The isurl filter works fine for me. Maybe steps I can repro the bug you're trying to fix. thanks

petr-tichy commented 10 years ago

My history contains something like this https://jira.example.com/secure/CreateIssueDetails!init.jspa?a=t&summary=Splunk%20bug&assignee=me but chrome.history.search with text="bug" doesn't return it, when the search string is only in the url.

amasad commented 10 years ago

yeah apparently, like you pointed out, it's not supported by chrome search. However searching for inurl:%20bug works.

Problem with the diff you sent is that it means we have to filter through a lot more results, which will make it very slow.