amastellone / mail-funnel-client

Mail-Funnel, a Shopify Embedded App available in the Shopify App Store
2 stars 3 forks source link

Javascript bugs #54

Open vaskaloidis opened 7 years ago

vaskaloidis commented 7 years ago

MailFunnel Client has 2 recent Javascript bugs. They have started recently, so they might be related to recent work - specifically the matt-updates-2-17 branch of code Matt contributed, because these issues started around that same time.

The second issue is probably caused by this other issue: The application.html.erb and embedded.html.erb layout files should be the same but one of them is using the application.js file which references Bootstrap and jquery libraries that are implemented as Gems in Gemfile. These need to be consolidated to one file with the same code - and this will probably fix the second bug (above) as a result. I think one file is being loaded sometimes, which is causing it to sometimes work and sometimes not work.

Matt I am giving this to you because it should be an easy fix