Bypass workspace form and entity restrictions

[pmelab]

Forms and non-managed entities are by default blocked in non-default workspaces. We had to bypass this for some cases by setting the entities to "internal" or manually re-enabling forms.

• Remove workspace modules entity form protection
• Re-enable entity moderation form
• Re-enable media library selection forms
• Allow files to be created in non-default workspace
• Allow crop entities to be created in non-default workspace

TODO:

• Investigate if this is a viable solution.
• Find a more generic implementation.

Resolution: delivery module

[amateescu]

• Remove workspace modules entity form protection

This should be done as a core patch that will depend on the conflict API issue/patch. A possible implementation would be that in the current code of the EntityChanged constraint, add this logic: if there is at least one "conflict resolver" class, follow the conflict management process, otherwise fallback to the current logic of the constraint.

• Re-enable entity moderation form: core patch

• Re-enable media library selection forms: core patch

• Allow files to be created in non-default workspace: core patch at https://www.drupal.org/project/drupal/issues/3027598 and we need a new issue to mark file entities as internal

• Allow crop entities to be created in non-default workspace: contrib patch

[pmelab]

On the media library form: There are a lot of candidates, and not all of them are patchable. Every views bulk operation form is blocked for example. And there might be a lot of contrib modules with utility forms in modals and the likes. They all have to marked as workspace_safe. I'm not sure this is a satisfying option.

[amateescu]

We have https://www.drupal.org/project/drupal/issues/2986005 for the VBO part, and all the other forms need to be considered on a case-by-case basis. There's really no way to know if submitting a form in a non-default workspace can have (user facing) consequence in the Live workspace.