search

amateescu / search_api_solr

11 stars 14 forks source link

Initial start of making the query method in search api solr more readable #21

Closed nickveenhof closed 9 years ago

nickveenhof commented 9 years ago

started by moving functions out to solrHelper to isolate them more. Also, stopped using arrays for passing information but use the solarium object to see what is there. Easier as that is what every phase needs to alter anyway. I would even more the query alterations for location to the location module actually.

drunken-monkey commented 9 years ago

I would even more the query alterations for location to the location module actually.

That would need a bit of a broader discussion, I think: https://www.drupal.org/node/2352475 I don't really know what makes more sense here: keeping all the code for a certain feature (in this case, location search) together, or keeping all the code for a certain backend together.

nickveenhof commented 9 years ago

Agreed that the query split-up logic needs to be discussed, so thanks for opening that. This pull request will only split out the functionality in to the solrHelper class but functionally it will stay the same