search

amateescu / search_api_solr

11 stars 14 forks source link

commitwithin implemented with solarium #26

Closed nickveenhof closed 9 years ago

Berdir commented 10 years ago

This seems to be working pretty well, does have a few drawbacks, though. One is that if you do things like manually indexing or clearing indexes, then the "Server index status" displays old values and you need to refresh again.

Which brings us back to the interactive vs non-interactive topic. Should Search API itself by extended to make it possible to set a flag to do delayed committing/updating if supported?

nickveenhof commented 10 years ago

I think the flag should even be enabled by default. If you use Solr you cannot, unless you use solrcloud, expect your changes to have effect instantly.

nickveenhof commented 10 years ago

To fix the confusion, we need to show the amount of pending deletes in the index UI: see http://localhost:8983/solr/d8/admin/mbeans?stats=true&cat=UPDATEHANDLER for getting this data. In Solr 3.6 you need to get the same data but then from stats.jsp. Please steal this from the Apache Solr module

Berdir commented 9 years ago

This needs a rebase, what is necessary to get this in?

amateescu commented 9 years ago

I guess we first need an agreement on whether we should do it or not? :) And most probably an opinion from @drunken-monkey as well.

Berdir commented 9 years ago

True. I've been using this on my project for a while now, obviously not a lot of data/indexing going on, but it has been very stable in the tests, unlike the current implementation.

drunken-monkey commented 9 years ago

I guess we first need an agreement on whether we should do it or not? :) And most probably an opinion from @drunken-monkey as well.

Looks like a good idea. The code is ugly as hell, but apparently that's how Solarium does it. Yikes. Anyways, sure, I'd vote for commiting that.

Berdir commented 9 years ago

I rebased this and created a new pull request in https://github.com/amateescu/search_api_solr/pull/39, commit is still from Nick, feel free to merge that.

amateescu commented 9 years ago

Merged #39.