Refactoring v0

[nisheetpatel]

Description

Includes major structural changes. Please review them before accepting.

Changes

Structural

• moved all source code to src folder
  • fixed all package imports by removing src from all imports
  • moved all evaluation scripts:
  • src/evaluate/main_eval.py, src/evaluate/main_eval_die.py, etc.
  • currently just dumped; will structure and organize later
  • moved training scripts and other helper scripts:
  • src/main.py, src/main_die.py
  • src/definitions.py (and updated ROOT_DIR definition to point to actual root, not src)
• added __init.py__ to all folders in src so they can be recognized as packages and imported properly by other modules

Functional

• added src/models/classifier.py with classifier base class and training functions
• added src/trainers/train_classifier.py and src/trainers/train_mixture_model.py
• added the following for training mixture model:
  • MixtureModelEnv class to envs/baoding.py
  • corresponding gym registration in src/envs/__init__.py
  • corresponding registration code to src/envs/environment_factory.py
• added a Trainer protocol and BaodingTrainer class in src/trainers/trainer.py to make main a little bit cleaner.
  • we could consider making a factory for trainer + envs + callbacks to make main really clean; but I didn't bother at the moment

Standardization

• added .vscode/settings.json and .pylintrc

Since we all use vscode, it's just a lot less annoying if everyone uses the same linter and formatting settings with auto-format. Otherwise whenever one of us pushes something, the others have issues. Happy to change any of the settings individually if you prefer some other autoformatter or whatever.

[nisheetpatel]

I also added a trainer class to make main a little bit cleaner and verified that it runs from root with python src/main_new.py as well as from src with python main_new.py. The one problem currently is that is it doesn't save main.py anymore. @albertochiappa could you perhaps tell me which callback that was a part of?

[albertochiappa]

The main_new.py seems to for me after removing the incompatibilities with python 3.7! I have removed everything related to ray and rllib, besides some further refactoring. Could you take a look that everything works as intended?

[nisheetpatel]

The main_new.py seems to for me after removing the incompatibilities with python 3.7! I have removed everything related to ray and rllib, besides some further refactoring. Could you take a look that everything works as intended?

Thanks for cleaning up. Looks great; just a couple of minor issues that I now fixed:

1. Added missing import os in src/metrics/custom_callbacks.py
2. Fixed broken EnvDumpCallback import in main_new.py; now importing from metrics.custom_callbacks instead of metrics.sb_callbacks
3. Deleted main.py and renamed main_new.py as main_baoding.py.