Fixes #5 and adds config for perf improvement.

amatiasq / vsc-sort-imports

Sort ES6 imports automatically.

ISC License

60 stars 22 forks source link

Fixes #5 and adds config for perf improvement. #10

Closed cliffkoh closed 6 years ago

cliffkoh commented 6 years ago

Introduced sort-imports.default-sort-style, which defaults to module-compact. Other possible values are module and eslint.
Introduced sort-imports.cache-package-json-config-checks which defaults to true. When true, will cache calls to import-sort-config thereby improving performance (avoids repeated non-trival disk lookups and parsing).
Fix bug in Save file without sorting import which caused it to not work.

cliffkoh commented 6 years ago

Made the changes requested, please help check :)

BTW, I found out bypass sort and save does not work, so I fixed it too... (I doubt it ever worked, unless it was a breaking change in VSCode extensibility APIs).

amatiasq commented 6 years ago

Yeah, it's possible that bypass sort and save never worked after the refactoring. This project needs some test to prevent that to happen again.

This PR fixed so many things, I'm going to release a new minor version now. Thanks, it's a great job!