search

amatiasq / vsc-sort-imports

Sort ES6 imports automatically.
ISC License
57 stars 24 forks source link

6.2.5: Cannot find module 'import-sort-style-eslint' #84

Closed OliverJAsh closed 3 years ago

OliverJAsh commented 3 years ago

I just upgraded from 6.2.4 to 6.2.5 and the extension no longer works. In the extension output I see this error:

Cannot find module 'import-sort-style-eslint'
jerome-benoit commented 3 years ago

That issue is not reproducible with various local test setups since https://github.com/amatiasq/vsc-sort-imports/pull/83 merge.

You have to give us a repository where you have the issue 100% of the time to allow more investigation.

Thanks.

OliverJAsh commented 3 years ago

@jerome-benoit Here you go: https://github.com/OliverJAsh/vsc-sort-imports-bug

secondfry commented 3 years ago

(to immediatelly fix this for you) Set your defaultSortStyle in extension settings.

"sort-imports.default-sort-style": "unsplash",
secondfry commented 3 years ago

So it seems there is a problem with package.json, extension settings and caching (as I mentioned in https://github.com/amatiasq/vsc-sort-imports/issues/82#issuecomment-820503979).

If I change extension settings they get picked up immediatelly. If I change package.json settings they are not recognized at all.

secondfry commented 3 years ago

And also reverting #83 resulted in import-sort-style-eslint successfully getting resolved (from bundled node_modules I guess). But then it won't resolve local projects modules.