search

amatiasq / vsc-sort-imports

Sort ES6 imports automatically.
ISC License
57 stars 24 forks source link

No extensions settings listed in GUI #93

Open AgainPsychoX opened 3 years ago

AgainPsychoX commented 3 years ago

Settings still works from settings.json but it would be nice to have those in nice settings GUI:

image

image

Example from other extension: image

jerome-benoit commented 2 years ago

Hello,

Settings still works from settings.json but it would be nice to have those in nice settings GUI:

https://user-images.githubusercontent.com/23557839/125440929-a828189f-4ee2-4e60-86cc-f494901e3e4a.png They can be put in various shared files like package.json in a repository to ensure all developers use the same settings to sort the import. Not sure it’s a desirable feature to allow to override them on the developer editor configuration …

-- Jérôme Benoit aka fraggle Piment Noir - https://piment-noir.org OpenPGP Key ID : 27B535D3 Key fingerprint : B799 BBF6 8EC8 911B B8D7 CDBC C3B1 92C6 27B5 35D3

AgainPsychoX commented 2 years ago

They can be put in various shared files like package.json in a repository to ensure all developers use the same settings to sort the import. Not sure it’s a desirable feature to allow to override them on the developer editor configuration …

What do you mean? I don't mean anything to override. The GUI is just shortcut for developer, so one don't have to edit the settings.json manually, isn't it?. As far I understand, the package.json file would still respected (sort-imports.default-sort-style and similar).

The issue is just feedback that there could be such GUI could enabled to ease developer editing the settings.

VS Code extensions can also add their own custom settings and they will be visible under an Extensions section.

jerome-benoit commented 2 years ago

The issue is just feedback that there could be such GUI could enabled to ease developer editing the settings.

VS Code extensions can also add their own custom settings and they will be visible under an Extensions section.

https://code.visualstudio.com/docs/getstarted/settings#_settings-editor https://code.visualstudio.com/docs/getstarted/settings#_settings-editor https://code.visualstudio.com/api/references/contribution-points#Configuration-schema https://code.visualstudio.com/api/references/contribution-points#Configuration-schema

We will accept PRs implementing it.

-- Jérôme Benoit aka fraggle Piment Noir - https://piment-noir.org OpenPGP Key ID : 27B535D3 Key fingerprint : B799 BBF6 8EC8 911B B8D7 CDBC C3B1 92C6 27B5 35D3