Fix backdrop remaining after submitting the Subscribe to a Feed dialog - Githubissues

amatriain / feedbunch

A simple and elegant feed reader.

http://feedbunch.com

MIT License

84 stars 11 forks source link

Fix backdrop remaining after submitting the Subscribe to a Feed dialog #8

Closed jtsay362 closed 9 years ago

jtsay362 commented 9 years ago

Due to a Twitter Bootstrap issue, sometimes after a modal is hidden, the backdrop remains. Workaround it by removing all backdrops after hiding. More details here: http://competa.com/blog/2013/11/how-to-stop-twitter-bootstrap-modal-dialogs-breaking-on-browser-history-navigation-in-angularjs/

amatriain commented 9 years ago

It looks good, I'm gonna merge it. Thanks!

However this fixes the issue only for the subscribe dialog. I see no reason why this couldn't also happen with other popups in the app:

invite a friend
delete profile confirmation dialog
help & feedback
keyboard shortcuts help
import subscriptions in OPML format
demo user credentials
create new folder
unsubscribe confirmation dialog

So after merging I'm going to make some changes so that the fix applies to any modal dialog, I hope you don't mind.