amatsuda / database_rewinder

minimalist's tiny and ultra-fast database cleaner
MIT License
807 stars 91 forks source link

Fix `.strategy=` for compatibility #17

Closed deeeki closed 10 years ago

deeeki commented 10 years ago

DatabaseRewinder should forward options to cleaners whenever .strategy= is called. Therefore, I also changed Cleaner#strategy= to overwrite options. So that’s compatible with DatabaseCleaner’s behavior.

While adding tests, I rewrote previous ones because they seem kinda redundant.

amatsuda commented 10 years ago

@deeeki Awesome! This problem was actually a "known bug" that had been in my TODO list since yesterday. I really appreciate your work! :rewind::rewind::rewind:

deeeki commented 10 years ago

Thanks, anytime! I also marked that on my list a few days ago :laughing: