search

amatsuda / database_rewinder

minimalist's tiny and ultra-fast database cleaner
MIT License
807 stars 91 forks source link

Support ruby 1.9.3 #6

Closed eitoball closed 7 years ago

eitoball commented 11 years ago

It might support 1.9.x, but I tested with only 1.9.3.

I want to use database_cleaner with project, but the project is on 1.9.3. So, I wrote this PR.

Ref: #1

amatsuda commented 10 years ago

@eitoball I'm so sorry that I've been ignoring this PR for 4 months long, but could you please try achieving the backward support by not increasing the number of .rb files? I hope the whole codebase to be as simple as possible, so I prefer simply rewriting every occurrence of kwargs and prepend into the Ruby 1 way rather than doubling the code to be maintained.

eitoball commented 10 years ago

@amatsuda thank you for reviewing. I will rewrite and re-push.

jmgarnier commented 10 years ago

I fixed the current code on https://github.com/21croissants/database_rewinder/tree/support_ruby_1_9_3

vizcay commented 10 years ago

I had to use 21croissants branch to get it to work with 1.9.3; it amazing.. full test suite from 13 minutes downto 4 !! By the way I'm using Firebird, not exactly a mainstream db adapter for rails.

+1 for supporting 1.9.3.. library adpotion > a bit of better code readibility in my opinion

amatsuda commented 7 years ago

I don't think any of you are still in need of 1.9 support.

eitoball commented 7 years ago

No, I don't. Thank you for your attention.