search

amatsuda / traceroute

A Rake task gem that helps you find the unused routes and controller actions for your Rails 3+ app
MIT License
903 stars 38 forks source link

feat: ignore helpers include in controllers #44

Closed MaximilianoGarciaRoe closed 8 months ago

MaximilianoGarciaRoe commented 2 years ago

Hi! I add a condition on defined_action_methods so that it does not consider includes Helpers, but only in the controllers separately considering only their includes

Why? Before when a controller included helpers, it considers them as unreachable_actions methods that were false positives, now with this change only include methods created in the controller

MaximilianoGarciaRoe commented 2 years ago

@amatsuda ?

hlascelles commented 2 years ago

@amatsuda what do you think?

hlascelles commented 7 months ago

Is this going to be in a new gem cut soon? Thanks!