search

amaury1093 / react-mapbox-gl-draw

Draw tools for Mapbox with React: 🗺️ react-mapbox-gl + 🖌️ mapbox-gl-draw
MIT License
183 stars 28 forks source link

Example not working correctly (any more) #564

Open StefanoOcchetti opened 2 years ago

StefanoOcchetti commented 2 years ago

The example is not running correctly any more.

1) package.json

"example": "yarn build && cd example && webpack-dev-server",

should become:

"example": "yarn build && cd example && webpack serve",

2) App.js

Controls are not shown. The following import is missing:

import 'mapbox-gl/dist/mapbox-gl.css';
amaury1093 commented 2 years ago

@StefanoOcchetti Thanks! Would you like to create a PR?

StefanoOcchetti commented 2 years ago

I'd love to... but I don't manage to push to a new branch... can you grant me new branch creation?

amaury1093 commented 2 years ago

You need to first fork the project, then push your branches to your fork (you have rights there), and the create a Pull Request from your fork to this repo.

StefanoOcchetti commented 2 years ago

yes, ok. I'll do that!

StefanoOcchetti commented 2 years ago

https://github.com/amaurym/react-mapbox-gl-draw/pull/565