Continue with the voice-sample where silence was removed?

amaurycrickx / recognito

Java Speaker Recognition Framework

Apache License 2.0

191 stars 102 forks source link

Continue with the voice-sample where silence was removed? #13

Open steff1193 opened 7 years ago

steff1193 commented 7 years ago

In Recognito.java method extractFeatures there is a line voiceDetector.removeSilence(voiceSample, sampleRate);. Shoud'nt it be voiceSample = voiceDetector.removeSilence(voiceSample, sampleRate); so that you actually use the output from removeSilence going forward in the method?

amaurycrickx commented 7 years ago

correct, well spotted !!!

isadoravs commented 6 years ago

Hello, in the same method (extractFeatures) in the line normalizer.normalize(voiceSample, sampleRate) shouldn't be voiceSample = normalizer.normalize(voiceSample, sampleRate)? And the normalize method shouldn't return a double[] audioSample?