amay077 / Xamarin.Forms.GoogleMaps

Map library for Xamarin.Forms using Google maps API
https://www.nuget.org/packages/Xamarin.Forms.GoogleMaps/
MIT License
546 stars 346 forks source link

Make Android MapRenderer.NativeMap overridable #640

Closed PaulWagener closed 5 years ago

PaulWagener commented 5 years ago

This is useful when someone wants to combine this library with a closed source library that provides its own GoogleMap instance.

I'm currently happily using this library, but have to combine it with a third party library that provides a SupportMapFragment subclass. I've got it working by overriding the MapRenderer.OnElementChanged() method and doing a lot of reflection as a substitute for calling the base method. By making the property virtual it allows a hook to provide a substitute GoogleMap instance.

amay077 commented 5 years ago

Thanks 👍