amay077 / Xamarin.Forms.GoogleMaps

Map library for Xamarin.Forms using Google maps API
https://www.nuget.org/packages/Xamarin.Forms.GoogleMaps/
MIT License
546 stars 346 forks source link

Pin label not shown on iOS 13.1.2 (on real devices) #663

Closed galadril closed 4 years ago

galadril commented 4 years ago

VERSIONS

PLATFORMS

ACTUAL BEHAVIOR

I've created a pin with Label and Address, but only the address is visible (see screenshot below)

ACTUAL SCREENSHOTS/STACKTRACE

afbeelding

EXPECTED BEHAVIOR

I actually set a label to that pin.. it works on a emulator thats on ios 13.1: afbeelding

HOW TO REPRODUCE

  1. On a real device, create a map with a pin that contains a label and address
  2. Click on the pin to open the info window. it now only shows the address
ppeau commented 4 years ago

the issue comes from the new theme "dark mode" in ios 13. If you switch it back to the light mode. You'll see your label again.

Something is not compatible with the new dark mode but I wonder if it may comes from the pin in Xamarin.Forms.Maps rather than Xamarin.Forms.GoogleMaps ?

amay077 commented 4 years ago

I think this is related with Google Maps SDK for iOS or Xamarin.Google.iOS.Maps.

We should wait for fix in these.

amay077 commented 4 years ago

I found fixed libraries.

I will depends Xamarin.Google.iOS.Maps 3.5.0.

galadril commented 4 years ago

Oh that would be awesome thanks! Looking forward for the update

amay077 commented 4 years ago

Fixed in https://www.nuget.org/packages/Xamarin.Forms.GoogleMaps/3.3.0 .

galadril commented 4 years ago

Great! Aldo i thought that it all worked but i get a linker exception:

warning : directory not found for option '-FGMps-3.5.0/Maps/Frameworks'
error : linker command failed with exit code 1 (use -v to see invocation)
error : warning: directory not found for option '-FGMps-3.5.0/Maps/Frameworks'

Framework not found GoogleMaps

amay077 commented 4 years ago

Do you update Deployment target to 9.0 in your iOS App's info.plist ?

Or ...

Clear and rebuild your solution:

galadril commented 4 years ago

i had the deployment target on 11.0.. let me check if the clean/rebuild works

galadril commented 4 years ago

I've tried all the cleaning, and the deployment target is 11.0 in info.plist, but I still get this linker exceptions as soon as i update Xamarin.Google.iOS.Maps to 3.5.0.

amay077 commented 4 years ago

Could you try XFGoogleMapSample and check difference between it and your proj.

galadril commented 4 years ago

Also the Sample project gives the same builderror for me. (#665 as wel)

rdonasco commented 4 years ago

Great! Aldo i thought that it all worked but i get a linker exception:

warning : directory not found for option '-FGMps-3.5.0/Maps/Frameworks'
error : linker command failed with exit code 1 (use -v to see invocation)
error : warning: directory not found for option '-FGMps-3.5.0/Maps/Frameworks'

Framework not found GoogleMaps

I have the same problem MTOUCH: error MT5202: Native linking failed. Please review the build log. clang: error : linker command failed with exit code 1 (use -v to see invocation) error MT5209: Native linkingerror : framework not found GoogleMaps error MT5209: Native linkingerror : warning: directory not found for option '-FGMps-3.5.0/Base/Frameworks' error MT5209: Native linkingerror : warning: directory not found for option '-FGMps-3.5.0/Maps/Frameworks'

rdonasco commented 4 years ago

Could you try XFGoogleMapSample and check difference between it and your proj.

strange, the sample works for me. :(, but my own project does not build.

AlonikiX commented 4 years ago

Could you try XFGoogleMapSample and check difference between it and your proj.

strange, the sample works for me. :(, but my own project does not build.

The same here. I am using Xamarin.Forms 4.3, could this be a problem?

iamlawrencev commented 4 years ago

Could be related to #666

rdonasco commented 4 years ago

Here's how I solved it. With your project still using nuget packages

  1. Remove the following directory and its contents. /Users/USER_HOME/.nuget/packages/xamarin.google.ios.maps/3.5.0
  2. Restore your nuget packages, this will recreate the v3.5.0 directory and its contents.
  3. Downgrade your project to use nuget packages
    • Xamarin.Forms.GoogleMaps v3.2.1
    • Xamarin.Google.IOS.Maps v3.1.0
  4. Build your project - this should go back to successful build.
  5. Upgrade your project to use
    • Xamarin.Forms.GoogleMaps v3.3.0
    • Xamarin.Google.IOS.Maps v3.5.0
    • Xamarin.Build.Download v0.4.1
  6. Edit Info.plist MinimumOSVersion = 10.0 <key>MinimumOSVersion</key> <string>10.0</string>
  7. Rebuild your project.