Pin is Sealed in Nuget package

amay077 / Xamarin.Forms.GoogleMaps

Map library for Xamarin.Forms using Google maps API

https://www.nuget.org/packages/Xamarin.Forms.GoogleMaps/

MIT License

545 stars 346 forks source link

Pin is Sealed in Nuget package #721

Open Pequeno0 opened 4 years ago

Pequeno0 commented 4 years ago

VERSIONS

Xamarin.Forms.GoogleMaps - 3.3.0

PLATFORMS

[x] Android
[x] iOS
[ ] UWP

ACTUAL BEHAVIOR

I can't inherit from the pin, even though you can from the normal Xamarin.Forms.Maps. Also I see that in the code here, sealed has been removed from pin.

EXPECTED BEHAVIOR

I want pin to not be sealed in the nuget package. - So please just release the newest version of the code. Or just a version where pin isn't sealed.

imsagarchopra commented 3 years ago

I am also waiting for this to happen as I want to display Url's on the Information window when you click on the pin which is not there in the default Pin class.

imsagarchopra commented 3 years ago

@amay077 when would you be able to push this fix to nuget release ?

yogeshk25 commented 2 years ago

@amay077 When will this be released on nuget? I see there is a PR#701 merged. but latest nuget package version 4.0.0-beta1, still has sealed class Pin

This is a must, in order to customize marker/pin by extending MapRenderer.