search

amazeeio / drupal-integrations

Add this project to any Drupal distribution based on drupal/core-composer-scaffold to enable it for use on Lagoon.
https://packagist.org/packages/amazeeio/drupal_integrations
1 stars 4 forks source link

Error with Drupal 10 / Symfony 6 #10

Closed dwoods closed 1 year ago

dwoods commented 1 year ago

When doing a 'lando pull' and probably other operations on a Drupal 10 site, it's throwing the following error:

Uncaught TypeError: Symfony\Component\Process\Process::__construct(): Argument #1 ($command) must be of type array, string given, called in /app/drush/Commands/contrib/drupal_integrations/src/LagoonCommands.php on line 194 and defined in /app/vendor/symfony/process/Process.php:143

It looks like Symfony Process(string) was changed to Process(array). After checking it appears this new signature was intruduced in Symfony 3.4, but recent versions must have removed the old syntax.

PR coming with a fix.

tobybellwood commented 1 year ago

Looks like it came in symfony 4.2 - https://github.com/symfony/symfony/pull/27821 - this would mean it's only available in Drupal 9 - we will need to look at how to treat any b/c

dwoods commented 1 year ago

Updated the PR with a check for the Symfony version, I wonder if that is a good solution for b/c? Tested on D10 but not D9 or D8 yet

tobybellwood commented 1 year ago

fixed in #11 #12 and #19