search

amazeeio / drupal-integrations

Add this project to any Drupal distribution based on drupal/core-composer-scaffold to enable it for use on Lagoon.
https://packagist.org/packages/amazeeio/drupal_integrations
1 stars 4 forks source link

Update Symfony Process() usage #11

Closed dwoods closed 1 year ago

dwoods commented 1 year ago

Fixes #10

bbenesh commented 1 year ago

I tested this locally and it fixed my issues with lando pull on a D10 site.

tobybellwood commented 1 year ago

I'm happy to not handle any b/c in the package - and just make this next release d9+ compatible only (as per https://github.com/amazeeio/drupal-integrations/pull/12).

I've not got an example set up to test d8/d9 - but I think @bbenesh might be able to check d9 with the original commit, and not worry about the fallback code?

bbenesh commented 1 year ago

I checked the original commit with my local D9 demo and it worked!

tobybellwood commented 1 year ago

Just reviewing this now, and it no longer works (with our test instance, running ssh portal/token) - will look into it

cli-drupal:/app$ drush la

In RequestException.php line 113:

  Client error: `POST https://api.main.lagoon-core.test6.amazee.io/graphql` resulted in a `401 Unauthorized` response:  
  {"errors":[{"message":"Unauthorized - Bearer token required"}]}
tobybellwood commented 1 year ago

I"m going to merge this, then PR the SSH Portal fix (it's a bit picker about commands, and doesn't like being passed the token and the 2&>1 redirect, so I'll handle errors in the mustRun