Adds ssh portal support

amazeeio / drupal-integrations

Add this project to any Drupal distribution based on drupal/core-composer-scaffold to enable it for use on Lagoon.

https://packagist.org/packages/amazeeio/drupal_integrations

1 stars 4 forks source link

Adds ssh portal support #9

Closed bomoko closed 11 months ago

bomoko commented 2 years ago

This is a POC of ssh portal support for drupal_integrations

On running a command, we alter the ssh options (host and ssh.options) to reflect anything that comes through via the openshift->sshHost and openshift->sshPort values for a Lagoon environment.

bomoko commented 2 years ago

Questions I have

Do we want to feature flag this?
Is there some order of precedence - if there are, for instance, hardcoded values for a particular environment, do we prefer those to what comes from the backend?

tobybellwood commented 2 years ago

Looks good so far. I think if we're assuming that a set sshHost and sshPort on the openshift object (is there another alias we can use?) means ssh portal, then no need to feature flag, as long as it works ok without them set?

Obviously this method provides an entirely new ssh.options in order to replace the sshPort - does it make more sense to replace the ssh port in the existing line, or is that too computationally hard? What is the likelihood of someone setting their own ssh.options?

bomoko commented 11 months ago

I'm closing this PR - while this works somewhat, it doesn't actually work for all use cases.