amazon-archives / amazon-cognito-auth-js

The Amazon Cognito Auth SDK for JavaScript simplifies adding sign-up, sign-in with user profile functionality to web apps.
Apache License 2.0
423 stars 232 forks source link

AdvancedSecurityDataCollectionFlag is always true #171

Open grmoon opened 5 years ago

grmoon commented 5 years ago

In lines 74-77 of CognitoAuth.js advancedSecurityDataCollectionFlag is set. This property is a boolean, however it can only ever be set to true due to the conditional before it is set from the AdvancedSecurityDataCollectionFlag passed to the constructor.

this.advancedSecurityDataCollectionFlag = true;
if (AdvancedSecurityDataCollectionFlag) {
    this.advancedSecurityDataCollectionFlag = AdvancedSecurityDataCollectionFlag;
}

These lines should really just be

this.advancedSecurityDataCollectionFlag = Boolean(AdvancedSecurityDataCollectionFlag);