amazon-archives / amazon-cognito-auth-js

The Amazon Cognito Auth SDK for JavaScript simplifies adding sign-up, sign-in with user profile functionality to web apps.
Apache License 2.0
424 stars 232 forks source link

parseCognitoWebResponse does not return any indication that there was no `code` parameter in the URL #189

Closed delissonjunio closed 5 years ago

delissonjunio commented 5 years ago

parseCognitoWebResponse will call the userhandler methods if it fails to retrieve cognito tokens after parsing the response URL, but that does not happen if it does not find a code parameter whatsoever. This makes it extremely hard to know if that succeeded or not.

delissonjunio commented 5 years ago

Nevermind, just realized this is fixed in https://github.com/aws/amazon-cognito-auth-js/pull/135. Thanks!