search

amazon-archives / amazon-cognito-identity-js

Amazon Cognito Identity SDK for JavaScript
Other
986 stars 452 forks source link

CookieStorage.setItem does not set the secure attribute #621

Closed numaroth closed 6 years ago

numaroth commented 6 years ago

Pretty much what it says in the title. CookieStorage.setItem does not set the secure attribute when calling Cookies.set.

Since the secure attribute is not passed through and the default of js-cookie is to set secure to false, it seems that no cookie made using CookieStorage will be set as secure.

itrestian commented 6 years ago

Great! Thanks for the pull request!