amazon-archives / amazon-cognito-identity-js

Amazon Cognito Identity SDK for JavaScript
Other
984 stars 454 forks source link

Adding lib folder. #652

Closed itrestian closed 6 years ago

jogold commented 6 years ago

Hi @itrestian, i don't understand why you are adding the lib folder to the repo. It's a build of src and should not be tracked, only included when publishing to npm. Otherwise it makes things complicated when making changes to the repo in the src folder.

itrestian commented 6 years ago

Yes but basically the main entry point in the package.json points to the lib folder and it makes things confusing for people that don't have it generated cause they require the library and it doesn't work.

jogold commented 6 years ago

People do not need to generate it, you have to build it and include it when publishing to npm, so when people require the library it will be there.

All npm repos work this way...