search

amazon-archives / amazon-cognito-identity-js

Amazon Cognito Identity SDK for JavaScript
Other
984 stars 454 forks source link

Add and update MFA typescript interface for CognitoUser #685

Closed woodcockjosh closed 6 years ago

woodcockjosh commented 6 years ago

There are some missing and inconsistent typescript interfaces for Cognito that cause compiler warnings when using in TypeScript projects. This will add those interfaces. Solution has been tested and implemented. Please let me know if you have any questions or changes you would like me to make.

On another note there are some interface methods which I don't understand and seem to be inconsistent with the other interfaces like associateSoftwareToken. Also it seems that challengeParameters is not JSON deserialized. If you like I could clean them up so that they are compatible with the rest of the library. Let me know.

itrestian commented 6 years ago

Can you make the above changes here: https://github.com/aws/aws-amplify/tree/master/packages/amazon-cognito-identity-js

woodcockjosh commented 6 years ago

Sure, I did. Should we close this one? Meaning no more changes to this repo?

itrestian commented 6 years ago

Thanks for the contribution. I see the PRs have been merged. Closing this.