Fix some lint issues and add `npm run build` for UMD module

jotto commented 7 years ago

This PR began as a couple of lint fixes so I could copy and paste the minified code into an existing project without blowing up eslint.

Then, it seemed easy enough to just create a UMD module definition. All that's left now is to push to the npm registry.

There are no tests to run, but I verified most functionality works as a browser global and require/import.

Usage in the browser doesn't change.
import 'amazon-cognito-js'; or require('amazon-cognito-js'); (after they push to npmjs.org)
to build, instead of grunt uglify, do npm run build (same command as amazon-cognito-identity-js)

itrestian commented 7 years ago

Thanks @jotto! I will bring up the pull request within the team in order to merge it. Weird that the callback in removeRecord was called in the body but not present in the function signature .

jotto commented 7 years ago

gentle ping

itrestian commented 7 years ago

Hi, can you confirm that we can use, modify, copy, and redistribute this PR? Thank you!

jotto commented 7 years ago

Hi, can you confirm that we can use, modify, copy, and redistribute this PR? Thank you!

I confirm that this PR can be used, modified, copied, and redistributed.

amazon-archives / amazon-cognito-js

Fix some lint issues and add `npm run build` for UMD module #36