amazon-archives / amazon-kinesis-connectors

Apache License 2.0
326 stars 190 forks source link

Setting Kinesis Client Library DynamoDB properties fails #89

Open Zambonilli opened 6 years ago

Zambonilli commented 6 years ago

When trying to set the Kinesis Client Library dynamoDB properties they are not being correctly passed to the Kinesis Client Library and applied. This issue looks to be caused by the connector's ExecutorBase class not including the dynamoDB parameters in the kinesisClientLibConfiguration's constructor.

I think the fix would be to add the properties for dynamoDB here, https://github.com/awslabs/amazon-kinesis-connectors/blob/master/src/main/java/com/amazonaws/services/kinesis/connectors/KinesisConnectorExecutorBase.java#L48

I can create a PR.