Let serverless know there's a process running

amazon-archives / aws-amplify-serverless-plugin

Plugin for the Serverless Framework to output AWS Amplify configuration files.

Apache License 2.0

124 stars 30 forks source link

Let serverless know there's a process running #39

Closed pfulop closed 5 years ago

pfulop commented 5 years ago

Currently if I run example or my own stack it doesn't generate any files. It looks like serverless is unaware there's process running in the background. If we change process to return the promise, serverless will actually wait for promise to be fulfilled.

Description of changes:

return resources constant from process function

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

thaerlabs commented 5 years ago

@adrianhall can we get this merged please? as @pfulop mentioned, now the serverless process will bail out before the files are actually written.

davidchannon commented 5 years ago

This need to be merged ASAP.

Figuring out what is going on here - vs the documentation and the examples is a real time killer.

adrianhall commented 5 years ago

Thanks for the fix. That is a little obscure, and took a while to figure out a test case that it actually fixed. Merging and going through the release process now.