amazon-archives / aws-cognito-angular-quickstart

An Angular(v5)-based QuickStart single-page app utilizing Amazon Cognito, S3, and DynamoDB (Serverless architecture)
https://cognito.budilov.com
Apache License 2.0
689 stars 304 forks source link

About a dozen files missing end-of-file ("trailing") newlines #140

Open ethanherbertson opened 6 years ago

ethanherbertson commented 6 years ago

A number of source files in this project are missing trailing newlines. It's obviously not a BIG deal, but failing to include trailing newlines can break all kinds of command-line tools.

→ find -type f -print0 | xargs -0 -L1 bash -c 'test "$(tail -c 1 "$0")" && echo "No new line at end of $0"'
No new line at end of ./app/public/auth/forgot/forgotPassword.component.ts
No new line at end of ./app/public/auth/resend/resendCode.component.ts
No new line at end of ./app/secure/landing/secureHome.css
No new line at end of ./app/service/s3.service.ts
No new line at end of ./app/service/user-parameters.service.ts
No new line at end of ./assets/css/bootstrap-theme.min.css
No new line at end of ./assets/css/bootstrap.min.css
No new line at end of ./assets/css/sb-admin-2.min.css
No new line at end of ./assets/fonts/fontawesome-webfont.svg
No new line at end of ./assets/fonts/fontawesome-webfont.woff2
No new line at end of ./assets/img/intro-bg.jpg
No new line at end of ./assets/ui-js/bootstrap.min.js
No new line at end of ./assets/ui-js/metisMenu.min.js
No new line at end of ./assets/ui-js/sb-admin-2.min.js
No new line at end of ./polyfills.ts
No new line at end of ./styles.css

"Binary" files like svg, jpg, and woff2 aren't really concerns, but all "code" files should end in a newline, basically without exception.