search

amazon-archives / aws-cognito-angular-quickstart

An Angular(v5)-based QuickStart single-page app utilizing Amazon Cognito, S3, and DynamoDB (Serverless architecture)
https://cognito.budilov.com
Apache License 2.0
689 stars 300 forks source link

General updates to createResources.sh #25

Closed gadams999 closed 7 years ago

gadams999 commented 7 years ago

This pull request enables the rest of the createResources.sh steps.

Example createResources.sh has a mixed case ROOT_NAME, which is used as part of the S3 bucket creation. Per the S3 bucket restrictions, one of the criteria for a bucket name is Bucket names can contain lowercase letters, numbers, and hyphens. This will fail during the creation of the bucket.

This pull request sets the ROOT_NAME portion of the bucket name to all lower case. Comment also added to indicate this.

Also corrected grep search for JSON where element order not guaranteed; specific AWS account needed for associating IAM role to Cognito Identity Pool. Captured in a later commit on my fork.

gadams999 commented 7 years ago

No worries, I'm here too. :) will update with some more context.

Sent from my iPhone

On Nov 28, 2016, at 16:45, Vladimir Budilov notifications@github.com wrote:

@vbudilov commented on this pull request.

Thanks for the updates! I'll have to check this out and run it...Probably after re:invent :)

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or mute the thread.