amazon-archives / aws-cognito-angular-quickstart

An Angular(v5)-based QuickStart single-page app utilizing Amazon Cognito, S3, and DynamoDB (Serverless architecture)
https://cognito.budilov.com
Apache License 2.0
689 stars 300 forks source link

Fixed ConfirmRegistration routing issues #33

Closed liquidcircle closed 7 years ago

vbudilov commented 7 years ago

Hi @liquidcircle ,

Let me review the changes.

Thanks, Vladimir

liquidcircle commented 7 years ago

Thanks Vladimir!

The repo steps are:

Currently this throws an error, rather than forwarding the user to the confirm registration page. Also note that the username (email address) wasn’t being passed correctly to the confirm registration page.

The next item on my list is to login the user after they register, rather than requiring the user to login. I’ll check that in as well, and let you know, if you’re keen on that change.

Cheers,

Alan

On Jan 6, 2017, at 10:14 AM, Vladimir Budilov notifications@github.com<mailto:notifications@github.com> wrote:

Vladimir

vbudilov commented 7 years ago

@liquidcircle ,

Thanks for the pull request -- I merged it but had a lot of local changes so the files moved around. Make sure you pull the latest.

Also, in regards to "The next item on my list is to login the user after they register, rather than requiring the user to login. I’ll check that in as well, and let you know, if you’re keen on that change." -- that's a helpful feature :) Just didn't have the time to implement this myself -- btw I hope you mean "after they confirm the code", rather than "register". Correct?

Thanks, Vladimir

liquidcircle commented 7 years ago

Thanks Vladimir!

Regarding the login piece, yes, correct... after they enter their confirmation code.

Cheers,

Alan