amazon-archives / aws-cognito-angular-quickstart

An Angular(v5)-based QuickStart single-page app utilizing Amazon Cognito, S3, and DynamoDB (Serverless architecture)
https://cognito.budilov.com
Apache License 2.0
689 stars 304 forks source link

sjcl, paranoia and entropy #43

Closed adamclerk closed 7 years ago

adamclerk commented 7 years ago

https://github.com/aws/amazon-cognito-identity-js/#random-numbers

The amazon-cognito-identity-js mentions using a paranoia of greater than 0 and calling startCollectors() on the sjcl library to provide entropy for older browser and mobile os'.

Any reason why it was not done within this quick start?

ghost commented 7 years ago

I believe this may be the reason.

https://github.com/aws/amazon-cognito-identity-js/pull/262/commits/e4fa8162c2921830be2ebc6d49fef121dcec3954

adamclerk commented 7 years ago

That PR was rejected and not pulled in.

It looks like this PR resolved the issue.

https://github.com/aws/amazon-cognito-identity-js/pull/281

Which makes my question moot.

Next question. Do you have plans to update the quickstart to use the new aws js lib (1.13.0)?

vbudilov commented 7 years ago

@adamclerk ,

There's no plan to upgrade the aws js lib as of now. You can use the following link to customize your sdk with the latest code: https://sdk.amazonaws.com/builder/js/