search

amazon-archives / aws-sdk-unity

ARCHIVED: The aws sdk for unity is now distributed as a part of aws sdk for dotnet:
https://github.com/aws/aws-sdk-net
Other
105 stars 43 forks source link

Analytics : session.stop events are missing global attributes and metrics #99

Closed noamgat closed 8 years ago

noamgat commented 8 years ago

Hi,

We are encountering an issue, that session.stop events sometimes don't carry global attributes and metrics that they were supposed to. After looking into the SDK's code, I think the problem is that the SessionStorage class does not contain the global attributes / metrics when it stores.

So if the flow is Go to background -> Wait for session timeout -> Resume then the global attributes/metrics will be sent, because they still exist in the context. But if the flow is Go to background -> kill app -> start app then the global attributes / metrics won't be sent.

I think the solution is simple - add the global metrics and attributes to the SessionStorage object.

karthiksaligrama commented 8 years ago

Thanks for bringing this up. Will update you when we have a fix. Until then we ask that you reinitialize global event before resume.

noamgat commented 8 years ago

Added a pull request that fixes this issue: https://github.com/aws/aws-sdk-unity/pull/115

karthiksaligrama commented 8 years ago

Continuing discussion on #115. Closing this issue