Add wait time to verify version created when publishing new app

amazon-archives / aws-serverlessrepo-python

A Python library with convenience helpers for working with the AWS Serverless Application Repository.

Apache License 2.0

23 stars 14 forks source link

Add wait time to verify version created when publishing new app #17

Closed paoptu023 closed 5 years ago

paoptu023 commented 5 years ago

Description of changes: If I immediately set permission to be public after creating a new app, it will give me a Only application with published version can use principal * exception because application version is created asynchronously. This PR is to add a wait time so that when publish_application returns the version is guaranteed to exist.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

paoptu023 commented 5 years ago

Close this PR after discussing with Lu. It's better to put the wait method in sam cli implementation since we know we are going to put policy after creating an app.