amazon-archives / aws-service-operator

AWS Service Operator allows you to create AWS resources using kubectl.
Apache License 2.0
732 stars 97 forks source link

Configmaps for services other than s3 missing #131

Open jgryszko opened 6 years ago

jgryszko commented 6 years ago

Is it planned to create config maps for other services than s3 (sqs, sns ...), or is there any reason, why it was omitted? Looking for areas to contribute...

christopherhein commented 6 years ago

There is not a reason, this would be a great first issue :)

ivanich commented 5 years ago

@christopherhein Any update on this? I've tried to add corresponding additional resource to sqsqueue.yaml model and rebuild aws-service-operator but it still doesn't create configmap for sqs. Basically what I tried so far:

  additionalResources:
    configMaps:
    - name: sqsCM
      data:
      - key: queueARN
        value: "{{.Obj.Output.QueueARN}}"
      - key: queueName
        value: "{{.Obj.Output.QueueName}}"
      - key: queueURL
        value: "{{.Obj.Output.QueueURL}}"

and then run "make rebuld" to regenerate and build code. Am I miss something?

ivanich commented 5 years ago

Turned out it never used my edited code but used unmodified sources from vendor dir.

christopherhein commented 5 years ago

Turned out it never used my edited code but used unmodified sources from vendor dir.

So you have it working?

ivanich commented 5 years ago

Turned out it never used my edited code but used unmodified sources from vendor dir.

So you have it working?

Yes, for some reason sources from vendor/github.com/awslabs/aws-service-operator/ was used. It would be nice to see configmap support for all resources in upstream as well as helm charts repo.