search

amazon-archives / aws-service-operator

AWS Service Operator allows you to create AWS resources using kubectl.
Apache License 2.0
730 stars 97 forks source link

Internalize codegen #133

Open joerocklin opened 6 years ago

joerocklin commented 6 years ago

Related to #62

Description of changes: This removes the need to separately install the codegen component. make build-codegen or make rebuild will handle preparing things. make aws-codegen (and callers) will then use the local binary.

It will also format the bindata code if it changes to preserve formatting.

Installation of go-bindata is still required. It would be nice to run this from a vendored source for consistency, maybe that can be a future effort.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

tantona commented 6 years ago

We include the changes from #136 in this PR

joerocklin commented 6 years ago

@christopherhein Can you help me understand why this was closed?

christopherhein commented 6 years ago

Sorry about thank @joerocklin thanks for calling that out. I was mistaken that this was the same as #136 but at second look you are right.

Any chance you can update the /Makefile target for rebuild to reference to call install-aws-codegen unless you feel there is a good reason to move this from an installed binary into a local package…