amazon-archives / aws-service-operator

AWS Service Operator allows you to create AWS resources using kubectl.
Apache License 2.0
732 stars 97 forks source link

Need support for lists in model #146

Closed sepulworld closed 5 years ago

sepulworld commented 5 years ago

Need support for lists in model

This currently doesn't work:

body:
    schema:
      type: object
      properties:
      - key: VpcSecurityGroupIds
        type: list
        description: |
          A list of VPC security group IDs. If your cache cluster isn't in a VPC, specify the CacheSecurityGroupNames property instead.
        structKey: VpcSecurityGroupIds
        templateKey: VpcSecurityGroupIds

https://github.com/kubernetes/gengo/blob/master/types/types.go#L403-L490 -- Here is list of builtin types supported in gogen, can we extend this easily?

sepulworld commented 5 years ago

This isn't needed. I just discovered the CommaDelimitedList data type in Cloud Formation ....

CommaDelimitedList
An array of literal strings that are separated by commas. The total number of strings should be one more than the total number of commas. Also, each member string is space trimmed.

For example, users could specify "test,dev,prod", and a Ref would result in ["test","dev","prod"].