amazon-archives / aws-service-operator

AWS Service Operator allows you to create AWS resources using kubectl.
Apache License 2.0
733 stars 103 forks source link

cluster-name is used in the sqs queue name #196

Open marcindulak opened 5 years ago

marcindulak commented 5 years ago

https://github.com/awslabs/aws-service-operator/blob/76312848693937324f5920d771cde1abe2f51fdd/configs/aws-service-operator.yaml#L235 is used when building the sqs queue name cluster-name + -cloudformation.

This may result in errors for clusters managed by kops

kubectl -n aws-service-operator logs aws-service-operator-56c7c574dc-dg4w6
time="2019-06-27T20:35:41Z" level=fatal msg="InvalidParameterValue: Can only include alphanumeric characters, hyphens, or underscores. 1 to 80 in length\n\tstatus code: 400, request id: e7541110-4cc1-57ea-b862-449f661c07bb"

since the conventions is to name kops clusters with as fqdn, separated by dots https://kubernetes.io/docs/setup/production-environment/tools/kops/#creating-a-cluster

I'm not sure what are other purposes where cluster-name is reused, but I see it also in the cloudformation stack names.