amazon-archives / aws-service-operator

AWS Service Operator allows you to create AWS resources using kubectl.
Apache License 2.0
733 stars 103 forks source link

Build Statically Linked Binary #201

Open computeracer opened 5 years ago

computeracer commented 5 years ago

Issue #202

Description of changes:

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

mhausenblas commented 5 years ago

@christopherhein any opinion on this?

christopherhein commented 5 years ago

@computeracer thanks for this PR. Are you trying to use goreleaser to build the images? The Makefile purpose for my use cases was local dev so I could test against a remote cluster then would build my images using goreleaser?

computeracer commented 5 years ago

I was building using the make file and putting the resultant binary into a container. I didnt realize goreleaser was recommended. Is there instructions on that?

On Fri, Jul 12, 2019, 11:49 AM Christopher Hein notifications@github.com wrote:

@computeracer https://github.com/computeracer thanks for this PR. Are you trying to use goreleaser to build the images? The Makefile purpose for my use cases was local dev so I could test against a remote cluster then would build my images using goreleaser?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/awslabs/aws-service-operator/pull/201?email_source=notifications&email_token=ADT7EL3YAOHCMKYZURZJML3P7CRX3A5CNFSM4IBVDST2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODZ2EOMA#issuecomment-510936880, or mute the thread https://github.com/notifications/unsubscribe-auth/ADT7EL6Q2PEE3NPKD5QCERDP7CRX3ANCNFSM4IBVDSTQ .

christopherhein commented 5 years ago

@computeracer no but PR's welcome. :) If you check out the Makefile you'll see the make release target, for your own env, you'll need to modify the .goreleaser.yml file in the root and change the dockers[].image param https://github.com/awslabs/aws-service-operator/blob/master/.goreleaser.yml#L45