search

amazon-archives / aws-service-operator

AWS Service Operator allows you to create AWS resources using kubectl.
Apache License 2.0
733 stars 103 forks source link

Fix fetching cloudformationtemplate object from k8s #210

Closed rtnpro closed 4 years ago

rtnpro commented 5 years ago

Issue #, if available:

Fixes #209

Description of changes:

Currently, when fetching cloudformation template object from Kubernetes, we fail to fetch the object from a specific namespace, even if the namespace is specified in the spec for an AWS service object like S3Bucket, etc., and coerce to using the 'default' namespace, which may not contain the cloudformation template objects.

This pull request allows fetching cloudformation temaplate objects from specified namespaces.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

rtnpro commented 4 years ago

@jaypipes What changes need to be done to get this code merged?

jaypipes commented 4 years ago

@jaypipes What changes need to be done to get this code merged?

Apologies, @rtnpro, I was on PTO and overseas...

I'll see about getting this merged ASAP.