amazon-archives / awsmobile-cli

CLI experience for Frontend developers in the JavaScript ecosystem.

Apache License 2.0

142 stars 35 forks source link

Added a --skip-deps flag to skip installing Amplify JS dependencies #164

Closed pangolingo closed 5 years ago

pangolingo commented 6 years ago

Issue #, if available:

146

Description of changes: In this PR I've added a --skip-deps or -s flag to the awsmobile init command. When this flag is set, Amplify JS dependencies will not be installed. A message "Skipping Amplify Dependency installation" will be shown.

See issue #146 for more details about why this is needed.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

codecov-io commented 6 years ago

Codecov Report

Merging #164 into master will increase coverage by 0.01%. The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #164      +/-   ##
==========================================
+ Coverage   80.85%   80.87%   +0.01%     
==========================================
  Files          85       85              
  Lines        5700     5704       +4     
  Branches      914      915       +1     
==========================================
+ Hits         4609     4613       +4     
  Misses        932      932              
  Partials      159      159

Impacted Files	Coverage Δ
lib/command-init.js	`100% <ø> (ø)`	:arrow_up:
lib/init-steps/s60-on-success.js	`98.18% <100%> (+0.14%)`	:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 7869de2...bee950c. Read the comment docs.

UnleashedMind commented 5 years ago

Support for the Amplify library is an important intended usage of the awsmobile cli, the current implementation is indeed a little rigid on this by installing the Amplify library at init, but init it a one pass operation, the cli user can easily remove the dependencies afterwards without loosing the cli functionalities.

pangolingo commented 5 years ago

@UnleashedMind I understand that Amplify is an important part of the CLI.

Do you have any recommendations for addressing the linked issue (#146)? Are you suggesting that we let awsmobile init clobber the existing package.json, and then reset it somehow? We could re-check it out from Git and then re-run yarn install. It seems pretty inelegant though.