search

amazon-archives / certlint

X.509 certificate linter
Apache License 2.0
157 stars 42 forks source link

Disable warning about multiple Given names and Surnames #69

Open AEtherC0r3 opened 5 years ago

AEtherC0r3 commented 5 years ago

Issue #, if available: X

Description of changes: At least in Greece, it is common for people to have 2 given names and in rare occasions 2 surnames.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Santhanraj commented 5 years ago

Hi,

Shouldn't they still be in a single attribute? E.g., surname of "Jon Doe" should be 2.5.4.4 = "Jon Doe" instead 2.5.4.4 = "Jon" 2.5.4.4 = "Doe"?

AEtherC0r3 commented 5 years ago

Hi, in your example I would prefer using a single attribute instead of two, but this isn't always possible.

RFC5280 imposes an upper bound on the length of the given name and surname attributes, which is 16 and 40 characters, respectively. E.g. If I had 2 given names e.g. "Antonios" and "Efstathios" then the length of 2.5.4.42="Antonios-Efstathios" is 19 and violates RFC5280, therefore, a reasonable solution to the issue is to use two attributes 2.5.4.42="Antonios" and 2.5.4.42="Efstathios".

The same applies to surnames, although I can't think of an appropriate example atm.