search

amazon-archives / dynamodb-janusgraph-storage-backend

The Amazon DynamoDB Storage Backend for JanusGraph
Apache License 2.0
447 stars 99 forks source link

Adding ScenarioTest for schema violations and locked transactions #202

Closed acs254 closed 7 years ago

acs254 commented 7 years ago

Hi Alexander,

I have been playing around with this project -- it's super cool. I added some class to generalize this a bit more. If this overcomplicates things, please let me know. Also, I added a new ScenarioTest to test these new classes. They compile, but there is usually multiple runtime errors due to some Schema violations and transactions being locked. I'd LOVE to figure out how to get these runtime exceptions to go away.

Addison

acs254 commented 7 years ago

I committed some additional changes. I'm not sure if there is anything else I need to do in order for you to preview and leave comments.

amcp commented 7 years ago

@acs254 I am taking a second look now. Thank you for your patience and understanding regarding minimal reproducing test cases.

amcp commented 7 years ago

@acs254 I created a new PR #205 to bring the work you started closer to completion (I made sure to keep your name on the commits you already provided, after squashing your six commits to one commit). I provided two example methods to load the same graph data, and demonstrated that both work in test cases. Thanks to you, I also noticed that the ScenarioTests were not running as part of the automated build, so I added them to the IsolateRemainingTestsCategory. Thank you!

amcp commented 7 years ago

@acs254 please comment on #205 if there is anything else you think needs to go in.