amazon-archives / dynamodb-janusgraph-storage-backend

The Amazon DynamoDB Storage Backend for JanusGraph
Apache License 2.0
447 stars 99 forks source link

storage.dynamodb.client.endpoint not set in dynamodb.properties #237

Closed jfstephe closed 7 years ago

jfstephe commented 7 years ago

dynamodb.properties doesn't have an entry for storage.dynamodb.client.endpoint, unlike the local and docker flavours, and according to the docs (and from what I can see from the code) there isn't a default.

Is this an oversight or by design? Can a comment be added to the dynamodb.properties file to explain this please?

amcp commented 7 years ago

@jfstephe This is by design. Recent versions of the AWS SDK built into this project prefer specifying the endpoint using the region (eg, us-west-1) rather than by endpoint. Most services do not have local versions like DynamoDB Local. I can add a comment suggesting an override in case you want to test with DynamoDB Local using the storage.dynamodb.client.endpoint configuration, but dynamodb-local.properties already does this.

jfstephe commented 7 years ago

Aaahhh ok.... ....perhaps a comment explaining why there is no endpoint in the non-local properties file or in the java code along the lines of what you said above might help peeps. Not urgent obviously, but if you are in that area [:-). Thanks for getting back to me.