amcp
commented
7 years ago Currently, there is one docker-compose file to pull together DynamoDB Local and the DynamoDB Storage Backend for JanusGraph. docker-compose is not needed for the DynamoDB service as it is always running. seems to me like we need the following:
- [ ] Two subdirectories for Docker, one for local and one for the service
- [ ] move the existing Dockerfiles and docker-compose to the local docker subdirectory
- [ ] a new Dockerfile for the DynamoDB service-enabled properties file
- [ ] instructions and possibly a script to publish the service images to ECR
- [ ] update to cloud formation to launch in a ECS container as opposed to a vanilla EC2 instance
Hi, IMHO the docker files for JanusGraph should not need as many 'flavours' as there are currently. I'd like to see a single Dockerfile for JanusGraph server and 2 different ones for dynamo DB (local and production). These would be brought together by 2 docker-compose files.
Further, I think they should be published to DockerHub. For example I'm using peopleperhour/dynamodb:latest but I'd rather this was published by awslabs.
I'm happy to create a PR, and for someone to publish to DockerHub but would like confirmation that this is what people want.
Also, one thing that killed me on titan was the Java artifact that is created (zip file etc) contains the version number. It would be helpful to the dockerfile creation and IMHO useful if this was removed from the zip file filename. I'm not that java-y, so if this against the java-Gods perhaps duplicate the file with and without the version in the filename? Dunno, open to suggestions.