search

amazon-archives / k8s-cloudwatch-adapter

An implementation of Kubernetes Custom Metrics API for Amazon CloudWatch
Apache License 2.0
158 stars 98 forks source link

Use default EKS IRSA ServiceAccount annotation in helm chart #47

Closed max-rocket-internet closed 4 years ago

max-rocket-internet commented 4 years ago

Currently in it's using iam.amazonaws.com/role: https://github.com/awslabs/k8s-cloudwatch-adapter/blob/master/chart/templates/serviceaccount.yaml#L8

But I think it should be using eks.amazonaws.com/role-arn since it's the proper annotation on AWS EKS?

Shivam9268 commented 4 years ago

Also Security Context needs to be added to the deployment as in #46