amazon-archives / k8s-cloudwatch-adapter

An implementation of Kubernetes Custom Metrics API for Amazon CloudWatch
Apache License 2.0
157 stars 98 forks source link

Helm Chart QoL Changes #50

Closed ericlarssen-wf closed 4 years ago

ericlarssen-wf commented 4 years ago

Description of changes: When trying to consume this chart, I have issue with number of things I needed to override. After recently consuming https://github.com/kubernetes/ingress-nginx, I notice some best practices that can be used here.

Secondly, I removed many explicit definitions of the namespace where we set it to the release namespace because helm will do that for you.

Finally, I made some changes around the service account by allowing the consumer to pass in a service account.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.